Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" #27768

huydhn · 2025-10-29T20:29:04Z

Purpose

This relands #27598 exactly as it is. For the CUDA 13.0 build failure in https://buildkite.com/vllm/release/builds/9637#019a3162-f87b-4fd4-820a-5612913b590e, I have added the missing xformers wheel for cu130 at https://download.pytorch.org/whl/cu130/xformers-0.0.33%2B5d4b92a5.d20251029-cp39-abi3-linux_x86_64.whl

Test Plan

https://buildkite.com/vllm/release/builds/9672 should all be green

@simon-mo

gemini-code-assist

Code Review

This pull request reapplies the installation of a pre-built xformers wheel, removing the previous build-from-source step in the Dockerfile. However, there appears to be a critical version mismatch in the xformers dependency specified in requirements/cuda.txt. The version in the file does not match the version mentioned in the pull request description, which was specifically added to fix a build failure. This should be corrected to ensure the build works as intended.

requirements/cuda.txt

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

requirements/cuda.txt

simon-mo

See bot comments

…vllm-project#27714) This reverts commit 9007bf5. Signed-off-by: Huy Do <huydhn@gmail.com>

Signed-off-by: Huy Do <huydhn@gmail.com>

noooop · 2025-10-30T04:00:12Z

Sorry to interrupt, unblock language-models-test-extended-pooling expect this PR to fix the main failure, but it didn't. (This failure might not be related to xformers.)

huydhn · 2025-10-30T04:22:00Z

Sorry to interrupt, unblock language-models-test-extended-pooling expect this PR to fix the main failure, but it didn't. (This failure might not be related to xformers.)

It makes sense that they are not related. This PR just swaps in a prebuilt xformers wheel instead of building it from source in exactly the same way.

noooop · 2025-10-30T04:29:01Z

Sorry to interrupt, unblock language-models-test-extended-pooling expect this PR to fix the main failure, but it didn't. (This failure might not be related to xformers.)

It makes sense that they are not related. This PR just swaps in a prebuilt xformers wheel instead of building it from source in exactly the same way.

I don't know why #27659 can succeed; what is the subtle difference between it and the main requirements?

https://buildkite.com/vllm/ci/builds/36673/steps/canvas?sid=019a2cf2-4410-4d56-9eec-27dd93dfe177

huydhn · 2025-10-30T05:59:57Z

@simon-mo I think those failures are the same nightly failures from before while https://buildkite.com/vllm/release/builds/9677 looks ok now

…t-2.9.0" (vllm-project#27768)" This reverts commit ba33e88.

…vllm-project#27768) Signed-off-by: Huy Do <huydhn@gmail.com>

ziruiliu · 2025-11-08T19:09:35Z

xformers==0.0.33+5d4b92a5.d20251029 only appears in cuda 13.0 prebuilt wheel.
For most people using cuda 12.X, the change breaks the installation

…vllm-project#27768) Signed-off-by: Huy Do <huydhn@gmail.com>

…t-2.9.0" (vllm-project#27768)" This reverts commit ba33e88.

…vllm-project#27768) Signed-off-by: Huy Do <huydhn@gmail.com> Signed-off-by: Eldar Kurtic <8884008+eldarkurtic@users.noreply.github.com>

tzulingk · 2025-11-14T04:03:42Z

when I tried to use deepseek-ai/DeepSeek-V2-Lite. I get the following error:

  File "/workspace/components/src/dynamo/vllm/main.py", line 115, in worker
    await init(runtime, config)
  File "/workspace/components/src/dynamo/vllm/main.py", line 413, in init
    engine_client, vllm_config, default_sampling_params = setup_vllm_engine(
                                                          ^^^^^^^^^^^^^^^^^^
  File "/workspace/components/src/dynamo/vllm/main.py", line 208, in setup_vllm_engine
    engine_args.create_model_config().get_diff_sampling_param()
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/vllm/vllm/engine/arg_utils.py", line 1186, in create_model_config
    return ModelConfig(
           ^^^^^^^^^^^^
  File "/opt/dynamo/venv/lib/python3.12/site-packages/pydantic/_internal/_dataclasses.py", line 123, in __init__
    s.__pydantic_validator__.validate_python(ArgsKwargs(args, kwargs), self_instance=s)
pydantic_core._pydantic_core.ValidationError: 1 validation error for ModelConfig
  Value error, Model architectures ['DeepseekV2ForCausalLM'] failed to be inspected. Please check the logs for more details. [type=value_error, input_value=ArgsKwargs((), {'model': ...rocessor_plugin': None}), input_type=ArgsKwargs]
    For further information visit https://errors.pydantic.dev/2.11/v/value_error

gemini-code-assist bot reviewed Oct 29, 2025

View reviewed changes

requirements/cuda.txt Outdated Show resolved Hide resolved

mergify bot added the ci/build label Oct 29, 2025

chatgpt-codex-connector bot reviewed Oct 29, 2025

View reviewed changes

requirements/cuda.txt Outdated Show resolved Hide resolved

simon-mo approved these changes Oct 29, 2025

View reviewed changes

huydhn added 2 commits October 29, 2025 13:43

Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" (…

7ba2115

…vllm-project#27714) This reverts commit 9007bf5. Signed-off-by: Huy Do <huydhn@gmail.com>

Bump the date

145906b

Signed-off-by: Huy Do <huydhn@gmail.com>

huydhn force-pushed the reland-use-prebuilt-xformers branch from 6f07867 to 145906b Compare October 29, 2025 21:00

simon-mo enabled auto-merge (squash) October 29, 2025 22:14

github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 29, 2025

Comment

7b89b53

Signed-off-by: Huy Do <huydhn@gmail.com>

auto-merge was automatically disabled October 30, 2025 01:25
Head branch was pushed to by a user without write access

simon-mo merged commit ba33e88 into vllm-project:main Oct 30, 2025
82 of 91 checks passed

0xC45 mentioned this pull request Oct 31, 2025

[Installation]: xformers issue #27851

Closed

1 task

luccafong added a commit to luccafong/vllm that referenced this pull request Nov 3, 2025

Revert "Reapply "Install pre-built xformers-0.0.32.post2 built with p…

9d20e5f

…t-2.9.0" (vllm-project#27768)" This reverts commit ba33e88.

ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025

Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" (…

9a6da72

…vllm-project#27768) Signed-off-by: Huy Do <huydhn@gmail.com>

rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025

Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" (…

93c0c9d

…vllm-project#27768) Signed-off-by: Huy Do <huydhn@gmail.com>

DarkLight1337 mentioned this pull request Nov 10, 2025

[Bug]: Latest v0.10.1 image can not run qwen2.5vl on 5090 due to xformer bug #23231

Closed

1 task

luccafong added a commit to luccafong/vllm that referenced this pull request Nov 11, 2025

Revert "Reapply "Install pre-built xformers-0.0.32.post2 built with p…

999481f

…t-2.9.0" (vllm-project#27768)" This reverts commit ba33e88.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" #27768

Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" #27768

Uh oh!

huydhn commented Oct 29, 2025 •

edited by github-actions bot

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

simon-mo left a comment

Uh oh!

noooop commented Oct 30, 2025

Uh oh!

huydhn commented Oct 30, 2025

Uh oh!

noooop commented Oct 30, 2025 •

edited

Loading

Uh oh!

huydhn commented Oct 30, 2025

Uh oh!

Uh oh!

ziruiliu commented Nov 8, 2025

Uh oh!

tzulingk commented Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" #27768

Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" #27768

Uh oh!

Conversation

huydhn commented Oct 29, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Test Plan

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

simon-mo left a comment

Choose a reason for hiding this comment

Uh oh!

noooop commented Oct 30, 2025

Uh oh!

huydhn commented Oct 30, 2025

Uh oh!

noooop commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huydhn commented Oct 30, 2025

Uh oh!

Uh oh!

ziruiliu commented Nov 8, 2025

Uh oh!

tzulingk commented Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

huydhn commented Oct 29, 2025 •

edited by github-actions bot

Loading

noooop commented Oct 30, 2025 •

edited

Loading